Advanced

Re: Exclude vs Excluded in "crc" func script

Exclude vs Excluded in "crc" func script
July 22, 2019 03:40PM
Hello,
I have noticed that we have inconsistency in the names of variables, specifically in the Generic (Country/Region/County) Checker func (by sumbloke). Link: https://project-gc.com/Tools/Challenges?edit&addTag&scriptId=1561

In description of the script there are specified parameters this way:

- "ExcludedTypes" - optional array, list all cache types to be EXCLUDED from results *
- "ExcludedCounties" - optional array, list all counties to be EXCLUDED from results
- "ExcludedRegions" - optional array, list all regions to be EXCLUDED from results
- "ExcludedCountries" - optional array, list all countries to be EXCLUDED from results
- "ExcludedGCCodes" - optional array, list all GC Codes to be EXCLUDED from results

While in the script source I can see different syntax:

filter['excludeCountries'] = conf.excludeCountries
filter['excludeRegions'] = conf.excludeRegions
filter['excludeCounties'] = conf.excludeCounties
filter['includeRegions'] = conf.includeRegions
filter['includeCounties'] = conf.includeCounties
filter['excludeCaches'] = conf.excludeCaches

Due to this inconsistency, we have quite a lot of incorrectly used parameters in the tags, especially in the Multiple test checker scripts by Target and Sumbloke.
https://project-gc.com/Tools/Challenges?edit&addTag&scriptId=937
https://project-gc.com/Tools/Challenges?edit&addTag&scriptId=1503

I don't know what would be the best approach, probably just:

- Fix description of func script by Sumbloke to align it with the source
- Fix all the individual tags, several tag owners involved

Any idea?

@sumbloke
@vogelbird
Re: Exclude vs Excluded in "crc" func script
July 22, 2019 03:53PM
There is inconsistency in names of parameters in the sumbloke's script itself .. just once fixed, we can fix the tags.
Sorry, you do not have permission to post/reply in this forum.