×

To be able to write in the forum you need to authenticate. Meanwhile it's read-only.

Change History

New api methods will be announced here. Changes in our data that is relevant to checkers scripts/tags will also be announced here.

Message: Broken scripts due to bad filtering

Changed By: magma1447
Change Date: May 17, 2019 09:01AM

Broken scripts due to bad filtering
I recently released a patch that denied filtering on region or county without providing a country. There are however a bit too many scripts that went broken by it. In some cases it's easy to fix the tag, in some cases the script has to be patched quite a lot.

One of the reasons why a country should be provided is mentioned in the last dot here:
[url=https://project-gc.com/forum/read?7,15,15#msg-15]Guidelines[/url]

The other reason is for performance reasons. The database index can't filter on neither region or county without having a country provided.

Since I don't have the time to go through the scripts and tags right now myself, I will revert the patch during the day. All in all it's around 1500 tags that seems to be affected. There might be others, and it might not be all these. The amount makes me wonder if I will ever be able to apply this patch again, but please, avoid increasing the amount at least. I'll attach the very long list as an answer to this post.
EDIT: Two answers, it was too large for one post.

If anyone feels like going through the tags and writing up all tag-ids where country can just be added as a fix, I can easily fix the tags on those after that.
An example is https://project-gc.com/Challenges//22969 . The script supports country, but it's not used. I looked at this particular one because I was author of the script myself, it made me curious.

Original Message

Author: magma1447
Date: May 17, 2019 08:57AM

Broken scripts due to bad filtering
I recently released a patch that denied filtering on region or county without providing a country. There are however a bit too many scripts that went broken by it. In some cases it's easy to fix the tag, in some cases the script has to be patched quite a lot.

One of the reasons why a country should be provided is mentioned in the last dot here:
[url=https://project-gc.com/forum/read?7,15,15#msg-15]Guidelines[/url]

The other reason is for performance reasons. The database index can't filter on neither region or county without having a country provided.

Since I don't have the time to go through the scripts and tags right now myself, I will revert the patch during the day. All in all it's around 1500 tags that seems to be affected. There might be others, and it might not be all these. The amount makes me wonder if I will ever be able to apply this patch again, but please, avoid increasing the amount at least. I'll attach the very long list as an answer to this post.